Open
Conversation
zhouwfang
force-pushed
the
zhoufang/iop-116-make-t-and-allowed_delta-configurable
branch
from
1c3ab17 to
d5e011c
Compare
zhouwfang
force-pushed
the
zhoufang/iop-116-make-t-and-allowed_delta-configurable
branch
from
d5e011c to
1cca276
Compare
jonas-lj
reviewed
Apr 10, 2026
| let (nodes, threshold) = build_reduced_nodes(&committee, allowed_delta, weight_divisor)?; | ||
| let (nodes, threshold) = build_reduced_nodes( | ||
| &committee, | ||
| threshold_basis_points, |
Contributor
There was a problem hiding this comment.
The name confused me a bit. You call it basis points here because you're defining the threshold as some ratio with a fixed denominator, MAX_BASIS_POINTS, and then use this to compute the threshold with the actual given weights, right? if so, I'd call this something else, like TOTAL_BASIS_WEIGHT, or just document the relationship with THRESHOLD_BASIS_POINTS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#368